Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

Add background color field to Scene #34

Closed
ibnc opened this issue Nov 8, 2013 · 1 comment
Closed

Add background color field to Scene #34

ibnc opened this issue Nov 8, 2013 · 1 comment

Comments

@ibnc
Copy link
Contributor

ibnc commented Nov 8, 2013

This is in order to complete servo/servo#140.

So, I've forked the repo, and made some changes, but whenever I try to build I get an error saying "can't find crate for 'geom'." I'm rather new to rust, and can't seem to get geom to install with rustpkg--as there is no main.rs/lib.rs/etc file.

Does there exist documentation on contributing to servo submodules?

Also, anyone have any objections to me importing azure, and having the background_color field just be a AzColor?

Help would be greatly appreciated!

@pcwalton
Copy link
Contributor

pcwalton commented Nov 8, 2013

Try using the main Servo makefile after you make changes. It may help to configure Servo with ./configure --disable-manage-submodules.

ibnc pushed a commit to ibnc/rust-layers that referenced this issue Nov 9, 2013
  Added background color attributes to scene
ibnc pushed a commit to ibnc/rust-layers that referenced this issue Nov 9, 2013
  Added background color attributes to scene
ibnc pushed a commit to ibnc/rust-layers that referenced this issue Nov 9, 2013
  Added background color attributes to scene
recrack pushed a commit to recrack/rust-layers that referenced this issue Nov 29, 2013
  Added background color attributes to scene
recrack pushed a commit to recrack/rust-layers that referenced this issue Nov 29, 2013
  Added background color attributes to scene
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants