Support std::iter::extend<T> for VecLike<T> #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 215d763 has been approved by |
|
☔ The latest upstream changes (presumably #26) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Superseded by #26. |
|
(not fully -- this PR also adds an |
|
🔒 Merge conflict |
|
Oh right. Could you rebase it? |
|
Adding a bound is a breaking change for implementors. Please change the version number accordingly. |
|
Rebased! I'll leave it to you to update the version number. |
|
@bors-servo r=nox |
|
📌 Commit e7e970a has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Aug 22, 2016
Support std::iter::extend<T> for VecLike<T> VecLike naturally supports push, so it also makes sense to support extend. Both implementors SmallVec and Vec already have tested implementations, so this extension feels natural. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/27) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VecLike naturally supports push, so it also makes sense to support extend. Both implementors SmallVec and Vec already have tested implementations, so this extension feels natural.
This change is