[breaking change] Update retain to use &mut instead of & #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mbrubeck |
mbrubeck
changed the title
|
Since this is a breaking change, we might want to consider if there are any other breaking changes we'd like to make, so that we can release them all together as smallvec 1.0.0. |
|
@mbrubeck well it's been almost 3 months and we haven't gotten any response on that. Do we just want to go ahead and merge it? |
|
@bors-servo r+ Yeah, sorry. I should have included this in the recent 0.5.0 release, but I forgot. It can go in the next version. |
|
📌 Commit 505833c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 15, 2017
[breaking change] Update retain to use &mut instead of & <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/61) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Dec 1, 2017
Version 0.6.0 Includes these changes since the last release: * Breaking change: Remove deprecated `SmallVecN` type aliases and `push_all_move` method (#77) * Breaking change: Make `retain` pass `&mut T` to its predicate (#61) * Add new methods `dedup`, `dedup_by`, and `dedup_by_key` (#72) * Deprecate the `VecLike` trait in favor of standard library traits (#74) * Optimize the `Clone` and `Deserialize` implementations to avoid unnecessary reallocation (#71) * Optimize `extend_from_slice` and `insert_from_slice` to use `copy_nonoverlapping` (#76) * Include the text of the Mozilla Public License in the source repo (#69) * Improved documentation (#75) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/78) <!-- Reviewable:end -->
|
Once that's stable, it would be nice to revert this, for drop-in compatibility with Also see the discussion in #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is