Update from ancient gcc dependency to cc #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Feb 8, 2022
|
@bors-servo r+ |
|
📌 Commit de72ca4 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Feb 8, 2022
Update from ancient gcc dependency to cc `gcc` was stuck in my dependency tree for a while, and this was the last remaining crate to use it. `gcc` has been renamed into `cc` and has seen significant improvements since then. The reason I've updated it now is because `gcc` didn't pick up our build environment properly while `cc` does.
|
This repo hasn't been migrated off of Travis yet. |
|
💥 Test timed out |
Not sure I fully understand this comment - should I switch this repo to github actions in this PR or is this an expectation that somebody else will pick up that work? |
|
I opened #99. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gccwas stuck in my dependency tree for a while, and this was the last remaining crate to use it.gcchas been renamed intoccand has seen significant improvements since then.The reason I've updated it now is because
gccdidn't pick up our build environment properly whileccdoes.