Skip to content

Implement Display for Host and HostAndPort #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue May 4, 2017 · 4 comments
Closed

Implement Display for Host and HostAndPort #300

brson opened this issue May 4, 2017 · 4 comments

Comments

@brson
Copy link
Contributor

brson commented May 4, 2017

Probably using the obvious serialization for "host:port". Looks like HostAndPort impl needs to be parameterized over S: Display.
@brson brson added easy labels May 4, 2017
@brson brson mentioned this issue May 4, 2017
Closed
19 tasks
@SimonSapin
Copy link
Member

For IPv6 addresses, using [] brackets is necessary to distinguish : within an address and : separating an address and port number. Display for Host already does this.

@tomecki tomecki mentioned this issue May 7, 2017
Merged
tmccombs added a commit to tmccombs/rust-url that referenced this issue May 16, 2017
@tmccombs
Implement Display and Debug for HostAndPort
9e7ba66 
Fixes servo#300
@tmccombs tmccombs mentioned this issue May 16, 2017
Closed
@luisbg
Copy link

luisbg commented May 20, 2017

Is anybody working on this?

kichristensen added a commit to kichristensen/rust-url that referenced this issue Jun 9, 2017
@kichristensen
Implement Display for HostAndPort
d74b627 
closes servo#300
@kichristensen kichristensen mentioned this issue Jun 9, 2017
Closed
bors-servo pushed a commit that referenced this issue Jun 13, 2017
Auto merge of #328 - tomecki:display_for_host_and_port, r=SimonSapin
4e909f6 
Add Display for HostAndPort

Fix #300

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/328)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

I kinda regret making HostAndPort a custom type rather than a tuple and I think making it implement Display just because is kind of cargo-culting, but whatever.

@luisbg
Copy link

luisbg commented Jun 13, 2017

Cool to see this added. Thanks @SimonSapin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Display for HostAndPort kichristensen/rust-url
3 participants
@brson @SimonSapin @luisbg