-
Notifications
You must be signed in to change notification settings - Fork 347
Update tests to Unicode 16.0 #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And the tests here are, of course, failing, because the new versions of the dependencies haven't been published, yet. Also, once |
…apter on Rust 1.67
And, of course ICU4X 1.x doesn't work with Unicode 16.0 test data, so that can't be tested. |
And, indeed, there are enough changes that the old test suite does not pass with Unicode 16.0 implementation internals. |
Timings building
|
Updating from ICU4X 1.5 (Unicode 15.1) to 2.0 (Unicode 16.0) increases the Brotli-compressed wasm-opt-optimized wasm footprint of |
ICU4X 1.5:
ICU4X 2.0:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage ? 80.11%
=======================================
Files ? 24
Lines ? 4355
Branches ? 0
=======================================
Hits ? 3489
Misses ? 866
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This updates the tests to Unicode 16.0. The test harness needs changes, because the earlier test suite had a bug concerning trailing dots. Now the test suite matches the spec text, but the deprecated
idna
API retains the behavior that was written to the old test suite bug.It is somewhat unfortunate the test suite is in this repo, but whether the code performs Unicode 16.0 behavior is up to the dependencies. Therefore, the expected landing sequence is this:
idna_adapter
1.2.1 from itsmain
branch.idna_mapping
1.1.0 from itsmain
branch.