Fix warnings and increase MSRV for 2.0 #508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I think I missed some AsciiExt occurences, don't approve yet... |
It is deprecated since 1.26.0 if the inherent methods, that are stable since 1.23.0, want to be relied on.
This requires at least rustc 1.24.0 as only then the function became stably const-fn.
The 1.24.0 release has been over a year ago and is needed by the prior commits.
est31
force-pushed
the
fix_warnings_msrv_increase
branch
from
b75339e to
bc09a23
Compare
|
Ok, all AsciiExt gone now. It can be reviewed! |
|
Ohhh this is the wrong branch, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some warning fixes as well as a MSRV increase from 1.17.0 to 1.24.0 (which is the oldest release the replacements for the deprecated functionalities are available). The first commit should be least controversial as it doesn't require any MSRV increase. Please say whether MSRV increases are a problem, if they are I can put the first commit into a separate PR.
Fixes #455
This change is