Skip to content

Fix lint warnings #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Fix lint warnings #781

merged 5 commits into from
Jul 28, 2022

Conversation

valenting
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #781 (0eb962d) into master (cbc6a6d) will decrease coverage by 0.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   85.31%   85.25%   -0.06%     
==========================================
  Files          22       22              
  Lines        3894     3894              
==========================================
- Hits         3322     3320       -2     
- Misses        572      574       +2     
Impacted Files Coverage Δ
idna/tests/uts46.rs 78.78% <0.00%> (+0.78%) ⬆️
url/tests/unit.rs 98.96% <ø> (-0.83%) ⬇️
idna/src/uts46.rs 94.13% <100.00%> (ø)
url/src/lib.rs 75.76% <100.00%> (ø)
url/src/parser.rs 81.32% <100.00%> (ø)
url/tests/data.rs 75.65% <100.00%> (ø)
url/src/host.rs 96.96% <0.00%> (+0.01%) ⬆️
data-url/tests/wpt.rs 85.71% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70539f2...0eb962d. Read the comment docs.

```
    Updating crates.io index
error: failed to get `serde` as a dependency of package `url v2.2.2 (/home/icecold/workspace/rust-url/url)`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  error reading from the zlib stream; class=Zlib (5)
```

Fixed by `CARGO_NET_GIT_FETCH_WITH_CLI=true cargo build --all-targets`
According to rust-lang/cargo#10303
@valenting valenting merged commit a72f83d into master Jul 28, 2022
@valenting valenting deleted the fix-lint-july branch June 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants