This repository was archived by the owner on Dec 16, 2024. It is now read-only.
[Proposal] Give @kvark reviewer privileges. #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark has make several important contributions to webrender, both as a reviewer and committer. He also has significant Rust experience previously as the author of gfx-rs. Some examples of recent reviews: servo/webrender#546 servo/webrender#523 servo/webrender#561 servo/webrender#554
|
@bors-servo r+ @kvark Thanks for all your awesome work so far, and I'm excited to have you as a new reviewer! |
|
📌 Commit ce4e2e3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2016
[Proposal] Give @kvark reviewer privileges. kvark has make several important contributions to webrender, both as a reviewer and committer. He also has significant Rust experience previously as the author of gfx-rs. Some examples of recent reviews: servo/webrender#546 servo/webrender#523 servo/webrender#561 servo/webrender#554 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/551) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
@larsbergstrom thank you! This ability is going to be helpful to us, at least for small Gecko-related changes. |
|
@kvark I will deploy it tomorrow morning (US Central time). I try not to make infra changes late at night :-) |
|
@kvark I lied, because I broke buildbot today for unrelated issues :-/ Tomorrow, really for sure! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kvark has make several important contributions to webrender,
both as a reviewer and committer. He also has significant
Rust experience previously as the author of gfx-rs.
Some examples of recent reviews:
servo/webrender#546
servo/webrender#523
servo/webrender#561
servo/webrender#554
This change is