Update cssparser #15766
Merged
Update cssparser #15766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
Do not merge yet, I’ll remove the |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Feb 28, 2017
Update cssparser <!-- Please describe your changes on the following line: --> servo/rust-cssparser#123 In particular, `match_ignore_ascii_case` now supports the full `match` syntax. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15766) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
Manishearth
reviewed
Feb 28, 2017
Cargo.toml
Outdated
| @@ -14,3 +14,6 @@ opt-level = 3 | |||
| # Uncomment to profile on Linux: | |||
| # debug = true | |||
| # lto = false | |||
|
|
|||
| [replace] | |||
| "cssparser:0.11.0" = {git = "https://github.com/servo/rust-cssparser", rev = "lol-replace"} | |||
There was a problem hiding this comment.
lol please don't replace? 😄
There was a problem hiding this comment.
Yes, this was only to be able to run on try before servo/rust-cssparser#123 landed, which conversely I didn’t land before making sure the Servo PR was ready, in order to avoid a deadlock where further cssparser changes would be blocked.
Manishearth
approved these changes
Feb 28, 2017
SimonSapin
force-pushed
the
cssparserup
branch
from
1efa9b5 to
288ef97
Compare
|
@bors-servo r=Manishearth |
|
📌 Commit 288ef97 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 28, 2017
Update cssparser <!-- Please describe your changes on the following line: --> servo/rust-cssparser#123 In particular, `match_ignore_ascii_case` now supports the full `match` syntax. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15766) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servo/rust-cssparser#123
In particular,
match_ignore_ascii_casenow supports the fullmatchsyntax../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is