script: copy include! files from script_bindings to script's OUT_DIR #36384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
wusyong
reviewed
Apr 7, 2025
wusyong
approved these changes
Apr 7, 2025
jdm
requested changes
Apr 7, 2025
Signed-off-by: sagudev <[email protected]>
TG199
pushed a commit
to TG199/servo
that referenced
this pull request
Apr 10, 2025
…ervo#36384) copy generated `include!`d files from script_bindings's OUT_DIR, to script's OUT_DIR to allow Rust Analyzer to load them. This is done to bypass limitation of Rust Analyzer: rust-lang/rust-analyzer#17040 Also build script will now be rerun only when there are actual changes to concrete bindings due to emitted `cargo::rerun-if-changed` (not for each change in script crate). Testing: It compiles so it works, I tested manually and RA now works as expected (although we need to from type alias to concrete union-types definitions) Fixes: https://servo.zulipchat.com/#narrow/channel/263398-general/topic/rust-analyzer.20failed.20to.20include.20codes.20in.20script_bindings --------- Signed-off-by: sagudev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy generated
include!d files from script_bindings's OUT_DIR, to script's OUT_DIR to allow Rust Analyzer to load them.This is done to bypass limitation of Rust Analyzer: rust-lang/rust-analyzer#17040
Also build script will now be rerun only when there are actual changes to concrete bindings due to emitted
cargo::rerun-if-changed(not for each change in script crate).Testing: It compiles so it works, I tested manually and RA now works as expected (although we need to from type alias to concrete union-types definitions)
Fixes: https://servo.zulipchat.com/#narrow/channel/263398-general/topic/rust-analyzer.20failed.20to.20include.20codes.20in.20script_bindings