work around a rustc bug #2708
Merged
work around a rustc bug #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc tries to expand enum tags to fill padding even if the requested size is smaller. This causes any code manipulating the enum's raw repr to produce buggy results, as it will write garbage into the padding, corrupting what rustc thinks is the tag. This is being fixed upstream, but for now just work around it by making the tags the same size rustc expects. See rust-lang/rust#50098
|
cc @eqrion and @RReverser, this is relevant to your interests. |
|
O_o Thanks for the ping! |
|
@bors-servo r+ |
|
📌 Commit dc129ab has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 30, 2018
work around a rustc bug rustc tries to expand enum tags to fill padding even if the requested size is smaller. This causes any code manipulating the enum's raw repr to produce buggy results, as it will write garbage into the padding, corrupting what rustc thinks is the tag. This is being fixed upstream, but for now just work around it by making the tags the same size rustc expects. See rust-lang/rust#50098 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2708) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc tries to expand enum tags to fill padding even if
the requested size is smaller. This causes any code
manipulating the enum's raw repr to produce buggy results,
as it will write garbage into the padding, corrupting
what rustc thinks is the tag. This is being fixed upstream,
but for now just work around it by making the tags the same
size rustc expects.
See rust-lang/rust#50098
This change is