Construct split planes with help of the inversed transform #3093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #3071) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Try looks good :) |
gw3583
approved these changes
Sep 20, 2018
|
@bors-servo r+ @kvark Looks good, thanks! I wonder if there is a way to add a wrench reftest for this as a follow up? |
|
📌 Commit 39b2633 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 20, 2018
Construct split planes with help of the inversed transform Fixes #3070 Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eb3a20402b513ccfa2d526b14f32ed707821e92 Meat of the fix is within `plane-split` 0.13.1 update, which we use in this PR in order to construct consistently transformed polygons for splitting. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3093) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
|
@gw3583 great idea! this shouldn't be too hard :) |
This was referenced Sep 21, 2018
bors-servo
pushed a commit
that referenced
this pull request
Sep 22, 2018
Update plane-split dependency A follow-up to #3093 Fixes #3096 Meat of the fix is in servo/plane-split#22 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3104) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Sep 23, 2018
Same-plane splitting reftest This is a follow-up to #3093 (comment) I confirmed that it's fixed by servo/plane-split@47c0826 specifically. r? anyone <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3102) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3070
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eb3a20402b513ccfa2d526b14f32ed707821e92
Meat of the fix is within
plane-split0.13.1 update, which we use in this PR in order to construct consistently transformed polygons for splitting.This change is