Pass device pixel scale via picture render task data. #3150
Conversation
|
Try run looks good. |
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gw3583)
webrender/res/snap.glsl, line 18 at r1 (raw file):
// the test cases we have in Servo that are failing without it // and seem better than not having this at all. snap_rect.size = max(snap_rect.size, vec2(1.0 / device_pixel_scale));
given the number of times we need to divide by it, we should probably provide the reciprocal (as an extra) from CPU side
webrender/src/device/gl.rs, line 527 at r1 (raw file):
id: gl::GLuint, u_transform: gl::GLint, u_device_pixel_ratio: gl::GLint,
🎉
|
☔ The latest upstream changes (presumably #3143) made this pull request unmergeable. Please resolve the merge conflicts. |
As a follow up, we will be able to include a per-picture local scaling factor. This can be used for drawing pictures in local space at a specific scale factor.
There was a problem hiding this comment.
Reviewable status: 6 of 15 files reviewed, 2 unresolved discussions (waiting on @kvark and @gw3583)
webrender/res/snap.glsl, line 18 at r1 (raw file):
Previously, kvark (Dzmitry Malyshau) wrote…
given the number of times we need to divide by it, we should probably provide the reciprocal (as an extra) from CPU side
Filed #3157
webrender/src/device/gl.rs, line 527 at r1 (raw file):
Previously, kvark (Dzmitry Malyshau) wrote…
🎉
Done.
|
Filed #3157 and rebased. I agree with the testing comment. I did a fair amount of manual testing in wrench with difference ratios, and it seems OK, but I'm not sure how good our CI coverage is. Once I start to leverage this for rasterizing pictures at different scales, we can definitely get some good CI coverage via that. |
|
@bors-servo r+ |
|
📌 Commit b0d7136 has been approved by |
Pass device pixel scale via picture render task data. As a follow up, we will be able to include a per-picture local scaling factor. This can be used for drawing pictures in local space at a specific scale factor. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3150) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
As a follow up, we will be able to include a per-picture
local scaling factor. This can be used for drawing pictures
in local space at a specific scale factor.
This change is