Fix a BlobImageRasterizer race condition. #3387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can only make a blob image rasterizer the render backend thread's current rasterizer after it went through the scene builder thread, otherwise the rastirezer might race ahead of other rasterizers that are on going through the scene builder thread. We also need to make sure that if there is a blob image update, we don't skip the scene builder thread.
|
r? @kvark |
kvark
approved these changes
Dec 6, 2018
|
@bors-servo r+ |
|
📌 Commit 094d296 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 6, 2018
Fix a BlobImageRasterizer race condition. We can only make a blob image rasterizer the render backend thread's current rasterizer after it went through the scene builder thread, otherwise the rastirezer might race ahead of other rasterizers that are on going through the scene builder thread. We also need to make sure that if there is a blob image update, we don't skip the scene builder thread. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3387) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 6, 2018
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 6, 2018
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893 UltraBlame original commit: ea5869ddc7dc02086e3c36e48af7b9e8a26678ca
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893 UltraBlame original commit: ea5869ddc7dc02086e3c36e48af7b9e8a26678ca
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893 UltraBlame original commit: ea5869ddc7dc02086e3c36e48af7b9e8a26678ca
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…f4023ee10d51 (WR PR #3387). r=kats servo/webrender#3387 Differential Revision: https://phabricator.services.mozilla.com/D13893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only make a blob image rasterizer the render backend thread's current rasterizer after it went through the scene builder thread, otherwise the rastirezer might race ahead of other rasterizers that are on going through the scene builder thread.
We also need to make sure that if there is a blob image update, we don't skip the scene builder thread.
This change is