Skip to content

Fix importing async classes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Fix importing async classes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5308ca0
Fix importing async classes
clmnin Jan 22, 2021
a72a919
Removed AsyncMapping as it is not implemented
clmnin Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions elasticsearch_dsl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@
from .document import AsyncDocument # noqa: F401
from .faceted_search import AsyncFacetedSearch # noqa: F401
from .index import AsyncIndex, AsyncIndexTemplate # noqa: F401
from .mapping import AsyncMapping # noqa: F401
from .search import AsyncMultiSearch, AsyncSearch # noqa: F401
from .update_by_query import AsyncUpdateByQuery # noqa: F401

Expand All @@ -176,7 +175,6 @@
"AsyncFacetedSearch",
"AsyncIndex",
"AsyncIndexTemplate",
"AsyncMapping",
"AsyncSearch",
"AsyncMultiSearch",
"AsyncUpdateByQuery",
Expand Down
2 changes: 1 addition & 1 deletion elasticsearch_dsl/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
]

try:
from ._sync import AsyncMultiSearch, AsyncSearch # noqa: F401
from ._async import AsyncMultiSearch, AsyncSearch # noqa: F401
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch here, thank you.


__all__.extend(["AsyncSearch", "AsyncMultiSearch"])
except ImportError:
Expand Down