Skip to content

Conversation

caspermeijn
Copy link
Contributor

The minimal version of openssl-macros needs to be the latest version. If 0.1.0 is used, then all kinds of compiler errors in the macro usage of openssl occur.

I found this by running cargo minimal-versions check on crate native-tls. I don't know of any simple CI check to add to this project to detect this problem in the future.

The minimal version of `openssl-macros` needs to be the latest version. If `0.1.0` is used, then all kinds of compiler errors in the macro usage of `openssl` occur.

I found this by running `cargo minimal-versions check` on crate `native-tls`. I don't know of any simple CI check to add to this project to detect this problem in the future.
@caspermeijn
Copy link
Contributor Author

Are these CI failures related to my changes?

 thread 'symm::tests::test_rc4' panicked at openssl/src/symm.rs:1090:83:
called `Result::unwrap()` on an `Err` value: ErrorStack([Error { code: 310378599, library: "DSO support routines", function: "dlfcn_load", reason: "could not load the shared library", file: "crypto/dso/dso_dlfcn.c", line: 118, data: "filename(/home/runner/work/rust-openssl/rust-openssl/target/arm-unknown-linux-gnueabihf/debug/build/openssl-sys-94390152d40c76fa/out/openssl-build/install/lib/ossl-modules/legacy.so): /home/runner/work/rust-openssl/rust-openssl/target/arm-unknown-linux-gnueabihf/debug/build/openssl-sys-94390152d40c76fa/out/openssl-build/install/lib/ossl-modules/legacy.so: cannot open shared object file: No such file or directory" }, Error { code: 310378599, library: "DSO support routines", function: "DSO_load", reason: "could not load the shared library", file: "crypto/dso/dso_lib.c", line: 147 }, Error { code: 126353445, library: "common libcrypto routines", function: "provider_init", file: "crypto/provider_core.c", line: 950, data: "name=legacy" }])

@sfackler
Copy link
Owner

@sfackler sfackler merged commit 96607c6 into sfackler:master Oct 28, 2024
61 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants