Send response messages in blocks #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our codec implementation originally just parsed single messages out of the stream buffer. However, if a query returns a bunch of rows, we're spending a ton of time shipping those individual messages from the connection back to the Query stream. Instead, collect blocks of unparsed messages that are as large as possible and send those back. This cuts the processing time of the following query in half, from ~10 seconds to ~5: `SELECT s.n, 'name' || s.n FROM generate_series(0, 9999999) AS s(n)` At this point, almost all of the remainder of the time is spent parsing the rows. cc #450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our codec implementation originally just parsed single messages out of
the stream buffer. However, if a query returns a bunch of rows, we're
spending a ton of time shipping those individual messages from the
connection back to the Query stream. Instead, collect blocks of unparsed
messages that are as large as possible and send those back.
This cuts the processing time of the following query in half, from ~10
seconds to ~5:
SELECT s.n, 'name' || s.n FROM generate_series(0, 9999999) AS s(n)At this point, almost all of the remainder of the time is spent parsing
the rows.
cc #450