Skip to content

Backward and forward-compatible changes to support zarr-python v3 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Dec 2, 2024

This is a cutdown version of #288 with all the straightforward changes that work with zarr-python v2, but still has some failures with v3 (mainly around string handling).

It should be OK to merge this and tackle the other v3 changes in another PR.

@coveralls
Copy link
Collaborator

coveralls commented Dec 2, 2024

Coverage Status

coverage: 98.869% (-0.04%) from 98.91%
when pulling 3256758 on tomwhite:zarr-python-v3-compatibility
into b9340c4 on sgkit-dev:main.

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @tomwhite !

@jeromekelleher jeromekelleher merged commit b1d7ef2 into sgkit-dev:main Dec 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants