Workaround dask#6631 #246
Merged
Workaround dask#6631 #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap around list to delegate eq to dask not std python
eric-czech
approved these changes
Sep 12, 2020
|
heh I have to believe that's not a change they intended. |
|
@eric-czech this is definitely a bug, see dask/dask#6631 for an analysis (and also why this workaround works), this essentially broke all dunder ops between Dask Array and non-scalar ... |
|
Crazy that it didn't break a test somewhere! |
|
We could also exclude Dask version 2.26.0, but this works too. I'm going to merge this manually now so we can move forward. |
Merged
ravwojdyla
added a commit
to ravwojdyla/sgkit
that referenced
this pull request
Sep 28, 2020
Dask 2.18.0 has the fixe included via dask/dask#6632 This reverts commit ffd85e0.
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
Dask 2.18.0 has the fixe included via dask/dask#6632 This reverts commit ffd85e0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #245