Skip to content

Split out docs requirements so they don't need to be installed on Windows #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

tomwhite
Copy link
Collaborator

The Windows CI build is failing because it crossed with #261 which introduced dependencies that are not available in conda (for Windows). These are scanpydoc and sphinx_autodoc_typehints.

Since we don't build docs on Windows, I've split out the docs requirements, and not included them for the Windows build.

Fixes #247

Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution

@tomwhite tomwhite merged commit 999f56b into sgkit-dev:master Sep 21, 2020
@tomwhite tomwhite deleted the fix-windows-ci branch September 21, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows CI
2 participants