Remove deadline and improve speed of max_str_len test #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 1967 1967
=======================================
Hits 1897 1897
Misses 70 70 Continue to review full report at Codecov.
|
tomwhite
approved these changes
Oct 20, 2020
jeromekelleher
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are small changes for https://github.com/pystatgen/sgkit/issues/336.
They improve the running time of a single test modestly and make it impossible for the test to fail the build again due to sporadic latencies.
I'm not sure what to do about deadlines in general (as mentioned in the issue), but perhaps disabling them when they become problematic is the best approach.
FYI these changes bring the total time for this test to run across all parameterizations down to ~1.5s (from ~6s), which is still annoyingly slow but a bit more palatable.