Eliminate automatically computed intermediate variables (for popgen) #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 96.49% 96.62% +0.13%
==========================================
Files 29 29
Lines 2053 2044 -9
==========================================
- Hits 1981 1975 -6
+ Misses 72 69 -3
Continue to review full report at Codecov.
|
|
Closing, since we decided not to do this. |
|
Should we file an issue to capture the “tighten up” approach discussed today? |
|
FYI I added some details on that in https://github.com/pystatgen/sgkit/issues/286#issuecomment-714664142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #286 for the popgen code. There is also some code in PCA that needs changing, but it may need #282 first - what do you think @eric-czech?