Skip to content

Make error message throws correctly on node<=0.12.x #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2016
Merged

Make error message throws correctly on node<=0.12.x #21

merged 1 commit into from
Jan 23, 2016

Conversation

AllenFang
Copy link
Contributor

I found the require.resolve will throws error when target module not found, so use try catch to make the error message for node<=0.12.x can throw correctly.

Review on Reviewable

@AllenFang AllenFang mentioned this pull request Jan 21, 2016
Closed
@alex35mil
Copy link
Member

Right, good catch, thanks! Merging 👍

alex35mil added a commit that referenced this pull request Jan 23, 2016
@alex35mil
Merge pull request #21 from AllenFang/master
f09730d 
Make error message throws correctly on node <= 0.12.x
@alex35mil alex35mil merged commit f09730d into shakacode:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllenFang @alex35mil