Skip to content

File organization #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin808 opened this issue Jan 24, 2016 · 3 comments
Closed

File organization #208

justin808 opened this issue Jan 24, 2016 · 3 comments

Comments

@justin808
Copy link
Member

Considerations:

move https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/bundles/comments/store/commentsStore.js

over to the startup directory

and rename file as commentsStoreCreator.js

CC: @alexfedoseev

@robwise
Copy link
Contributor

robwise commented Jan 24, 2016

@justin808 @alexfedoseev why are we reinventing the wheel here? We have ReactOnRails specific code, it goes in the startup folder. Otherwise, we just do what the convention for Redux apps is: https://github.com/rackt/redux/tree/master/examples/todomvc/store

It's called configureStore and it goes in its own store folder.

@justin808
Copy link
Member Author

6 of one, half dozen of other

configureStore is good

@robwise
Copy link
Contributor

robwise commented Jan 24, 2016

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants