Updated eslint-config-shakacode to 13.2.0 #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robwise @alexfedoseev @dylangrafmyre FYI, this is a sort of a big change. Don't apply this to any times there are many branches pending. However, if all branches run the autofix, you'd be fine. |
justin808
force-pushed
the
update-linter
branch
from
754f96f to
eef6227
Compare
justin808
force-pushed
the
update-linter
branch
from
2a5bb17 to
d3f6bf5
Compare
justin808
commented
Nov 25, 2016
| @@ -2,7 +2,7 @@ import Alert from 'react-bootstrap/lib/Alert'; | |||
| import BaseComponent from 'libs/components/BaseComponent'; | |||
| import Immutable from 'immutable'; | |||
| import React, { PropTypes } from 'react'; | |||
| import ReactCSSTransitionGroup from 'react/lib/ReactCSSTransitionGroup'; | |||
| import ReactCSSTransitionGroup from 'react-addons-css-transition-group'; | |||
justin808
commented
Nov 25, 2016
| @@ -16,13 +16,26 @@ | |||
|
|
|||
| # Forms | |||
| shared_context "Horizontal Form", form: :horizontal do | |||
| background { click_link "Horizontal Form" } | |||
| background do | |||
There was a problem hiding this comment.
FYI @dylangrafmyre you might want to try some of this in our projects.
justin808
commented
Nov 25, 2016
| @@ -6,6 +6,7 @@ | |||
| require File.expand_path("../../config/environment", __FILE__) | |||
| require "rspec/rails" | |||
| require "capybara/rspec" | |||
| require "capybara/poltergeist" | |||
There was a problem hiding this comment.
FYI @dylangrafmyre you might want to try some of this in our projects
justin808
commented
Nov 25, 2016
| '-o-animation: none !important;' + | ||
| '-moz-animation: none !important;' + | ||
| '-ms-animation: none !important;' + | ||
| '-webkit-animation: none !important;'; |
There was a problem hiding this comment.
FYI @dylangrafmyre you might want to try some of this in our projects
justin808
commented
Nov 25, 2016
| PhantomJSRestart.call | ||
| puts "=" * 80 |
There was a problem hiding this comment.
FYI @dylangrafmyre you might want to try some of this in our projects
Big change is that trailing commas are the default for function calls.
Autofixer makes this easy!
Be sure to run
npm run lint -- --fix
and you will be updated!
NOTE: Webpack config files must not have this set as of now, or else you
get a syntax error.
Webpack files need this, as they error if there's a trailing comma for
function calls!
/* eslint comma-dangle: ["error",
{"functions": "never", "arrays": "only-multiline", "objects":
"only-multiline"} ] */
justin808
force-pushed
the
update-linter
branch
from
5dfa690 to
2e1d118
Compare
* Seeting default driver to poltergeist_errors_ok * Added file to make poltergeist retry * more on the poltergeist trap Errno::EPIPE * add travis to slack integration * Change react-addons-css-transition-group * Update npm version * Update shrinkwrap * set npm to 4.0.2 * add npm install * Update node version 7.2.0 * travis runs poltergeist_errors_ok
justin808
force-pushed
the
update-linter
branch
from
2e1d118 to
69c03cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autofixer makes this easy to update to latest.
Be sure to run
npm run lint -- --fix
and you will be updated!
This change is