Skip to content

Fix travis #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2018
Merged

Fix travis #437

merged 6 commits into from
Apr 22, 2018

Conversation

Judahmeek
Copy link
Collaborator

@Judahmeek Judahmeek commented Apr 20, 2018

This change is Reviewable

@Judahmeek Judahmeek requested a review from justin808 April 20, 2018 09:57
@justin808
Copy link
Member

:lgtm:

see questions

don't remove code coverage?


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


.travis.yml, line 5 at r1 (raw file):

rvm:
  - 2.4.1
sudo: false

why this changed?


spec/rails_helper.rb, line 4 at r1 (raw file):

ENV["RAILS_ENV"] ||= "test"
require "coveralls"
Coveralls.wear!("rails") # must occur before any of your application code is required

why removing coveralls


Comments from Reviewable

@Judahmeek
Copy link
Collaborator Author

I'll add it back. I removed it because it was giving a weird error I didn't want to yak shave.


Review status: all files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 5 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why this changed?

I assumed this need to be switched to true because I use sudo commands to upgrade chrome.


spec/rails_helper.rb, line 4 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why removing coveralls

I'll put it back.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants