Initialize dockerized version #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thetonyrom This looks great. However, we really should take out the QT dependency and remove https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/Gemfile#L97... There are a few other references to capybara-webkit in the repo. We're actually going beyond headless chrome and using cypress.io for testing. |
|
@justin808 I see your point. I have a pretty busy week, probably, I'll update the PR in the coming weekend. |
|
@justin808 I've updated the PR, have a look |
|
I'm about to make a new PR that fixes your CI issue. rebase on top of that and push again, please. |
|
@thetonyrom Can you rebase on top of master and push. |
|
Done |
|
Hey @justin808 . Let's finish it! :) Let me know if anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #331
This change is