Skip to content

remove jquery_ujs dependency to fix #169 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2016
Merged

remove jquery_ujs dependency to fix #169 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/generators/react_on_rails/templates/base/base/client/webpack.client.base.config.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ module.exports = {
vendor: [
'babel-core/polyfill',
'jquery',
'jquery-ujs',
'react',
'react-dom',
],
Expand Down
4 changes: 3 additions & 1 deletion lib/generators/react_on_rails/templates/base/base/client/webpack.client.rails.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ config.entry.vendor.unshift(
'es5-shim/es5-sham'
);

// See webpack.common.config for adding modules common to both the webpack dev server and rails
// jquery-ujs MUST GO AFTER jquery, so must use 'push'
config.entry.app.push('jquery-ujs');

// See webpack.common.config for adding modules common to both the webpack dev server and rails
config.module.loaders.push(
{test: /\.jsx?$/, loader: 'babel-loader', exclude: /node_modules/},
{test: require.resolve('react'), loader: 'imports?shim=es5-shim/es5-shim&sham=es5-shim/es5-sham'}
Expand Down