Support direct react components and server console messages and linting #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support to React components generated with React.createClass() - Add “generator” property to allow creating a React component via a function - Add HelloES5 component to the dummy application
- Renaming Ruby variables to snake case - Make ReactRenderer#render_js_react_element a class method - Improve generated JS code
* Added console & error logging * Catch exceptions and log them on the server side * Issue with HelloWorld component is not loade properly. Visit /focused to see the issue * Created /focused so that a specific part can be individually tested. * Lots of cleanup and refactoring. * Consistency with using suffix App for generator functions * Added default for generator_function
|
@alexfedoseev @josiasds Please pull this code. I need some help. This is really close, but if you go to http://localhost:3000/focused then you'll see the error which is that the HelloWorld component is not found. This is doing simple client rendering. Same issue server rendering. Thanks. Also, we added the option for the helper of |
This was referenced Sep 13, 2015
| @@ -1,7 +1,7 @@ | |||
| import React from 'react'; | |||
|
|
|||
| // Super simple example of the simplest possible React component | |||
| export default class HelloWorld extends React.Component { | |||
There was a problem hiding this comment.
Why do we need to split definition and export if we don't do anything with exported class?
There was a problem hiding this comment.
@alexfedoseev We don't need to split. We were experimenting. Voodoo coding.
|
|
||
| <<-HTML.strip_heredoc.html_safe | ||
| #{data_from_server_script_tag} | ||
| #{rendered_output} |
index.html.erb crashing need to put all the example in separate web pages with clear explanations of what is being demonstrated
* Also catches when generator_function is set to true when it's not a generator function. * Reuse the same catch on both client and server. * Started to format JS code better. * Some readme improvements
| @@ -88,10 +109,11 @@ Contributions and pull requests welcome! | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Add this line to your application's Gemfile: | |||
| Add these linesto your application's Gemfile, sustituting your preferable JavaScript engine. | |||
justin808
changed the title
# Conflicts: # README.md # spec/dummy/Gemfile.lock # spec/dummy/bin/setup # spec/dummy/spec/rails_helper.rb # spec/dummy/spec/spec_helper.rb
All tests passing
justin808
added a commit
that referenced
this pull request
Sep 20, 2015
Support direct react components and server console messages and linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visit /focused to see the issue
Replace #19