Resolution to issue #11 as raised and debugged by dcodeIO #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by dcodeIO. Improves bcrypt-nodejs compatability with the bcrypt package
|
👍 Looking forward to seeing this merged in. |
fpirsch
added a commit
to fpirsch/twin-bcrypt
that referenced
this pull request
Jun 26, 2014
Improves compatability with the bcrypt package. See shaneMangudi/bcrypt-nodejs#14 and shaneMangudi/bcrypt-nodejs#21
|
It'd be sweet to see this merged in, or even just a mention in the docs that the progress argument in .hash() needs to be |
|
@markau @julianlam @TessMyers This seems to have been partially fixed, but might not be as complete as this fix. Can one of you update the PR, and I will get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves bcrypt-nodejs compatability with the bcrypt package.
i.e. when writing code against the bcrypt library, and changing libraries to use bcrypt-nodejs instead, node raises a runtime error which is resolved with this change.