Skip to content

Planned features for v0.3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
sherter opened this issue Mar 6, 2016 · 6 comments
Closed
3 tasks done

Planned features for v0.3 #4

sherter opened this issue Mar 6, 2016 · 6 comments
Milestone
v0.3

Comments

@sherter
Copy link
Owner

sherter commented Mar 6, 2016 •
edited
Loading

  • Improved logging (ad50810, c948cef)
  • Performance: cache results of verification tasks (863a12a)
  • support for formatter options (995f659 and others)
@sherter sherter added this to the v0.3 milestone Mar 6, 2016
@tbroyer
Copy link
Contributor

tbroyer commented Apr 12, 2016

support for formatter options

👍 At least provide option to sort imports (and maybe sort by default BTW)

sherter added a commit that referenced this issue Apr 19, 2016
@sherter
Introduce abstraction layer for google-java-format
f5fda62 
This additional abstraction layer hopefully makes it easier to cope with
google-java-format and different versions of it, especially in
preparation for options support (see issue #4)
@sherter
Copy link
Owner Author

sherter commented Apr 19, 2016

👍 At least provide option to sort imports (and maybe sort by default BTW)

I started to work on this, but it seems like sorting imports is broken in google-java-format

@tbroyer
Copy link
Contributor

tbroyer commented Apr 19, 2016

I see you're still defaulting to 0.1-alpha, have you tried with the recent 1.0?

@sherter
Copy link
Owner Author

sherter commented Apr 19, 2016 •
edited
Loading

Yes, I tried it with 1.0. There is no API for options in 0.1-alpha.

sherter added a commit that referenced this issue Apr 28, 2016
@sherter
Introduce abstraction layer for google-java-format
0f3cc05 
This additional abstraction layer hopefully makes it easier to cope with
google-java-format and different versions of it, especially in
preparation for options support (see issue #4)
@sherter
Copy link
Owner Author

sherter commented Jun 2, 2016

I thought about options support again and I think I want to follow the idea of google-java-format and provide as little configuration options as possible. For now I'm going to provide only the style option ('AOSP'/'GOOGLE'). A Javadoc formatter is turned on by default (ECLIPSE for 1.0). It should be easy now to add more options later, if someone has an actual use case.

@tbroyer I will also turn on imports sorting by default when google/google-java-format#42 is resolved. Do you have a use case for turning it off?

@tbroyer
Copy link
Contributor

tbroyer commented Jun 2, 2016

No, my concern was being able to turn it on, not off ;-)

@sherter sherter closed this as completed Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
2 participants
@tbroyer @sherter