Update JSON API Client to 1.6.0 #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired_fields_on_customer_account
mzishtiaq
force-pushed
the
upgrade_json_api_client
branch
from
49c0694 to
6229b56
Compare
added 2 commits
March 4, 2021 10:51
mzishtiaq
changed the title
added 2 commits
April 1, 2021 17:40
praweb
reviewed
Apr 6, 2021
| ) | ||
| request(:post, klass.path(record.attributes), { | ||
| body: { data: record.as_json_api }, | ||
| params: record.request_params&.to_params |
There was a problem hiding this comment.
Actually is request_params coming as nil is acceptable here?
There was a problem hiding this comment.
Yes because it doesn't look like we are using it but I don't want to remove it for all cases.
praweb
reviewed
Apr 6, 2021
| ) | ||
| request(:patch, resource_path(record.attributes), { | ||
| body: { data: record.as_json_api }, | ||
| params: record.request_params&.to_params |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test suite and updates JSON API client to 1.6.4. We have noticed some issues while trying an update previously so this will need to be tested before releasing.