Schmir/upgrade go ethereum #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a segfault when shutting down a tendermint validator. Please note that the tendermint configuration file now mostyly uses snake case instead of kebab case. Also, we now generate validator keys even when running a node in seed/boot mode. I couldn't get it to start otherwise. See #388
This fixes problems with go mod tidy
Unfortunately we cannot use v1.13.0, as that breaks our tests. See ethereum/go-ethereum#28078 and NomicFoundation/hardhat#4438
konradkonrad
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-ethereum and abigen to v1.12.0
Unfortunately we cannot use v1.13.0, as that breaks our tests. See
ethereum/go-ethereum#28078 and
NomicFoundation/hardhat#4438
This is based on the schmir/upgrade-tendermint branch. Only look at the last commit.