namedPlaceholders cannot be disabled at query level

[wellwelwel]

• As reported in chore: improve coverage and good practices for tests #2472

When setting namedPlaceholders globally (connection level) to true, it's not possible to disable it at the query level.

---

To reproduce, just uncomment this test:

node-mysql2/test/esm/integration/named-placeholders.test.mjs

Lines 18 to 29 in 41d21eb

	// test(() => {
	// const c = createConnection({ namedPlaceholders: true });
	// c.query({ sql: query, namedPlaceholders: false }, values, (err) => {
	// c.end();
	// assert(
	// err || err?.sqlMessage.match(/right syntax to use near ':named'/),
	// 'Enabled in connection config, disabled in query command',
	// );
	// });
	// });

---

The opposite will work fine:

node-mysql2/test/esm/integration/named-placeholders.test.mjs

Lines 31 to 44 in 41d21eb

	test(() => {
	const c = createConnection({ namedPlaceholders: false });
	c.query({ sql: query, namedPlaceholders: true }, values, (err, rows) => {
	c.end();
	assert.ifError(err);
	assert.equal(
	rows[0].result,
	1,
	'Disabled in connection config, enabled in query command',
	);
	});
	});

[tfrancois]

I confirmed that this is still an issue with version 3.14.1. It works when enabling at query-level when enabling only for a specific query (where globally it is disabled), but not disabling it when it is globally enabled in pool config options.

Any update if and when this important feature can be resolved?

[tfrancois]

Not sure if this is related in any way, but as I responded to Issue #2169, I was able to bypass the SQL error when I attempted to use the query-level namedPlaceholders inline modification.

So instead of:

...connection.query({ "sql": "<<SOME SQL HERE>>", "values": [ true, false ], "namedPlaceholders": false })

I reverted to the normal positional-based parameter arguments:

...connection.query("<<SOME SQL HERE>>", [ true, false ])

...worked for me without error. This however does not afford me the ability to modify the namedPlaceholders property setting at query level but at least the library doesn't reject with the Error code: 1064; SQLState: 42000 error(s).