Skip to content

Conversation

lenovouser
Copy link

Closes #8

@huan huan requested a review from simonepri March 13, 2019 15:16
@lenovouser
Copy link
Author

Ping @huan @simonepri

@simonepri
Copy link
Owner

simonepri commented Apr 13, 2019

@lenovouser sorry, this slipped under my radar, thanks for the ping.

@simonepri
Copy link
Owner

@lenovouser
Can you fix the typing to match these guidelines? (Ignore the one about using tabs and use 2 space indentation instead)
You can find a good example here

Thanks!

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2c71d95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   86.95%           
=========================================
  Files             ?        6           
  Lines             ?      138           
  Branches          ?        0           
=========================================
  Hits              ?      120           
  Misses            ?       18           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c71d95...395b454. Read the comment docs.

@lenovouser
Copy link
Author

@simonepri no problem. Should be done!

@lenovouser
Copy link
Author

@simonepri ping 😃

@lenovouser
Copy link
Author

@simonepri I think this is ready to merge 🚀

@soyuka soyuka merged commit 9fcd92b into simonepri:master Jul 2, 2019
@soyuka
Copy link
Collaborator

soyuka commented Jul 2, 2019

tyvm @lenovouser !

@lenovouser lenovouser deleted the add-types branch July 2, 2019 08:47
simonepri added a commit that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript support
5 participants