Skip to content

Reference terminology terms #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #83

@harrytodorov harrytodorov linked an issue Apr 6, 2021 that may be closed by this pull request
Add a fixed versions for both requirements
As fixing the sphinx and recommonmark requirements did not fix the failing
build in Read the Docs, try to fix the other requiremetns as from the
Docker container, which builds without isssues
Cross-referencing seems not to work properly when using an enumerated
list. The guide for hoverxref recommends using sections
It seems ReStructuredText loves blank lines, so there must be a blank
line between a ref and a section heading
the getting started document
@harrytodorov
Copy link
Contributor

harrytodorov commented Apr 8, 2021

Please use this link to see the changes, as sphinx-hoverxref makes use of the "Read the Docs" API to retrieve referenced terms.

As suggested by @pablo-de-andres, the sphinx-hoverxref extension has been used to add tooltips to the terminology terms. The extension uses the :ref: role from Sphinx to cross-reference documents (see here), thus at the places we would like to use tooltips we need to convert paragraphs into ReStructuredText (currently most of the documentation is written using Markdown). This makes the adding of tooltips quite cumbersome as there are some major differences between the two formatting languages (e.g. in how links for example are formatted; ReStructuredText is very verbose).

Therefore (as suggested by @yoavnash), tooltips are added only in the "General architecture" section. If necessary in the future, they can be added to different documents.

Note: In addition to adding tooltips to the terminology terms, this issue has been used to fix a failing "Read the Docs" build. Commits 635088b and 895c334 are dealing with this.

@harrytodorov harrytodorov marked this pull request as ready for review April 8, 2021 14:41
Copy link
Member

@pablo-de-andres pablo-de-andres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how sustainable this will be in the long term, considering the overhead it takes to manually have to add a term

@harrytodorov
Copy link
Contributor

harrytodorov commented Apr 9, 2021

I'm not sure how sustainable this will be in the long term, considering the overhead it takes to manually have to add a term

I agree with you, Pablo. I don't like it as well. It is hard to integrate when Markdown is the main formatting language. I was thinking of opening an issue on their repository asking about potential Markdown support.

My second issue with the extension is that it does not give you any options of automatically "registering" terms. Say, for example, we want to "register" the term OSP and at each occurrence of it to have a tooltip over it. Or even better, to have a tooltip over it in its first N occurrences for a given user, and then remove the tooltips, as to not annoy the user.

Appended 1:
Another alternative to the Markdown support would be inlining ReStructuredText in Markdown. @pablo-de-andres do you know whether recommonmark supports this? This would clean up the code a bit more

Appended 2:
I've added an issue on the sphinx-hoverxref GitHub repository asking about Markdown support. See here

@yoavnash yoavnash closed this Apr 9, 2021
@harrytodorov harrytodorov added the wontfix This will not be worked on label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants