ntf server: PostgreSQL database storage #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
7 times, most recently
from
9dbd2ac to
a52f8e1
Compare
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
commented
Apr 21, 2025
epoberezkin
force-pushed
the
ep/ntf-storage
branch
from
8cad8cc to
d15f641
Compare
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
from
11705ca to
d7e2c1b
Compare
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
from
3ed1f9b to
8870111
Compare
spaced4ndy
reviewed
Apr 22, 2025
spaced4ndy
reviewed
Apr 22, 2025
| srvId :: Int64 <- ExceptT $ upsertServer db $ ntfSubServer' sub | ||
| n <- liftIO $ DB.execute db insertNtfSubQuery (ntfSubToRow srvId sub) | ||
| withLog "addNtfSubscription" st (`logCreateSubscriptionRec` sub) | ||
| pure $ n > 0 |
There was a problem hiding this comment.
what's the semantic for this - "any subscriptions created" or something more specific? better give it a name
spaced4ndy
reviewed
Apr 22, 2025
spaced4ndy
reviewed
Apr 22, 2025
spaced4ndy
reviewed
Apr 22, 2025
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
from
ac14175 to
e030f5d
Compare
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
2 times, most recently
from
e96a512 to
1ace0f7
Compare
… subscriptions on conflict, improve server insertion, remove duplicate tokens for import, remove subscriptions without tokens for import
epoberezkin
force-pushed
the
ep/ntf-storage-postgres
branch
from
1ace0f7 to
76ddcab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.