prevent start if already started - fixes #5 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ Ora.prototype.render = function () { | |||
| }; | |||
|
|
|||
| Ora.prototype.start = function () { | |||
| if (!this.enabled) { | |||
| if (!this.enabled || this.id) { | |||
There was a problem hiding this comment.
if (!(this.enabled && this.id)) {Would be clearer.
There was a problem hiding this comment.
Those are not identical. The first time, enabled is false and id is undefined which will result in false and because of the ! will result in true and the spinner won't start. Did you mean
if (this.enabled && this.id) {If the spinner is enabled AND we have an id, do nothing.
|
// @dylang |
|
Nice work @SamVerschueren, I was thinking the same idea for a fix for this. Do you think it would helpful to add a test for this that would fail without this fix? I'm not sure the best way to test, here's one idea: // psudocode-ish
spinner.start();
const idAfterFirstStart = spinner.id;
spinner.start();
const idAfterSecondStart = spinner.id;
if (idAfterFirstStart !== idAfterSecondStart) {
throw new Error('spinner was restarted instead of continuing from previous start.');
} |
|
@dylang would be helpfull indeed. Will add it to the PR. |
|
Added tests |
| spinner.start(); | ||
| const id = spinner.id; | ||
| spinner.start(); | ||
| t.same(id, spinner.id); |
There was a problem hiding this comment.
Good catch :)!
sindresorhus
pushed a commit
that referenced
this pull request
Mar 28, 2016
|
Thanks Sam :) |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes #5. At least, I think it does :). As long as the interval is running (and thus the spinner is spinning), multiple calls to
startwon't do a thing.