Skip to content

Respect trailing newline at the end of the file #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 30, 2019
Merged

Respect trailing newline at the end of the file #27

merged 6 commits into from
Jul 30, 2019

Conversation

privatenumber
Copy link
Contributor

@privatenumber privatenumber commented Jul 24, 2019 •
edited by sindresorhus
Loading

Fixes #26

This PR adds functionality to detect EOF and respect it

Hiroki Osame added 2 commits July 23, 2019 23:33
sindresorhus
sindresorhus requested changes Jul 26, 2019
View reviewed changes
@sindresorhus
Copy link
Owner

The PR needs a better title too.

@privatenumber privatenumber changed the title Respect EOF Respect trailing new line at the end of file Jul 27, 2019
@privatenumber
Copy link
Contributor Author

@sindresorhus Addressed all review comments

@sindresorhus sindresorhus changed the title Respect trailing new line at the end of file Respect trailing newline at the end of the file Jul 30, 2019
@sindresorhus sindresorhus merged commit 7257ebb into sindresorhus:master Jul 30, 2019
@privatenumber privatenumber deleted the respect-eof branch July 30, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New line at EOF
2 participants
@privatenumber @sindresorhus