Explicitly disable chown for file writes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in write-file-atomic saving to a permissionless filesystem ( eg fat32, exfat ) in linux without explicitly setting chown to false, causes the write to fail. As noted here: npm/write-file-atomic#58 By simply setting chown argument explicitly, this error will not occur.
|
Can you elaborate on why it's not needed? |
Sure. Currently the code is calling write-file with no chown option setting. This has the unintended consequence of chowning the file to current user ( due to the behaviour of write-file-atomic ). It's not necessary to chown a file to write to it, only that the permissions be correct. On linux permissionless filesystems like exfat and fat32 the entire filesystem is normally owned by root, and trying to chown it causes as permissions error. The best solution is to simply specify to write-file-atomic to not change the owner of the file being written to. |
sindresorhus
changed the title
|
Thanks for elaborating. |
|
You're welcome. Thanks for incorporating the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in write-file-atomic saving to a permissionless filesystem ( eg fat32, exfat ) in linux without explicitly setting chown to false, causes the write to fail. As noted here: npm/write-file-atomic#58
By simply setting chown argument explicitly, this error will not occur.