-
Notifications
You must be signed in to change notification settings - Fork 922
chore!: move spell checker to example #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'm fine with these changes, however, I think it's important to point out in the project's README that having this feature could increase the bundle size.
Thanks for taking the time to make these changes.
As you mentioned, it's best to focus for now on the existing code that still causes some issues (some I haven't been able to find the solution for).
…dicates this feature doesn't support many translations
… and remove the part regarding the supported translations.
Description
Remove
simple_spell_checker
fromflutter_quill_extensions
to make it optional in order to reduce bundle size. Implementing this feature in the example.This PR will not require any additional changes to build the app however it will disable the spell-checking feature.
Initially, I planned on moving this feature into a new package (
flutter_quill_spell_checker
) and while doing so, I decided to only implement it in the example for a few reasons.The
README.md
has been updated.Apologies for the frequent breaking changes; we're continuously refining decisions to improve the project's direction.
Tip
For existing apps that expect this feature, you can take a look at the example and Spelling checker page.
Open to feedback—feel free to ask any questions or share thoughts.
Related Issues
Type of Change
Suggestions
I recommend that we focus on code quality by refactoring and enhancing the existing code, documenting it, making it more extensible by allowing to write extensions to provide any feature in a clean way, and more tests since we have regressions more often than before.