-
Notifications
You must be signed in to change notification settings - Fork 924
chore: remove device_info_plus and add quill_native_bridge to access platform specific APIs #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you have suggestions or thoughts regarding this PR, I'm open to hearing them. For the plugin name, I would go for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem.
Supporting iOS simulator is VERY important.
The flutter_ prefix is redundant and is good to remove.
I don't have a preference on quill_platform_bridge or quill_native_bridge. Platform gives the idea that this is platform-specific. Native gives the idea that it is low level native code that could do whatever.
Description
Remove
device_info_plus
and create aquill_native_bridge
plugin for accessing platform-specific APIsCurrently, we have
device_info_plus
as a dependency to fix a bug on iOS simulator (See #652) by check if the device is an iOS simulator, removing the plugin and addquill_native_bridge
which currently can only check if the platform is iOS simulator, we might expand it in the future since we need platform-specific APIs in some areas such as accessing the clipboard and spell checker system service.This PR doesn't make
flutter_quill
a plugin, instead, it creates a new plugin and requires it as a dependency influtter_quill
.Moving packages into their own directory
We might consider moving the packages into their own directory (
packages
) however there are some places that need to be manually updated first:flutter_quill
in the other packages (likeflutter_quill_extensions
)quill_native_bridge/ios/quill_native_bridge.podspec
We will discuss it in a different issue later.
Related Issues
Type of Change