Api clean up for LightGBM. The cleanup includes:

- Changing all abbreviated parameters to full names (i.e. numThreads->NumberOfThreads)
- Updating column parameters to have Name if thats what they represent
(LabelColumn->LabelColumnName).
- Updated baseline files to reflect these changes which are semantical
and should not have any computational difference.

This fixes dotnet#2618

Author: singlis

docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Ranking/LightGbm.cs

@@ -20,10 +20,10 @@ public static void Example()
 
             // Create the Estimator pipeline. For simplicity, we will train a small tree with 4 leaves and 2 boosting iterations.
             var pipeline = mlContext.Ranking.Trainers.LightGbm(
-                numLeaves: 4,
-                minDataPerLeaf: 10,
+                leafCount: 4,
+                minimumDataPerLeaf: 10,
                 learningRate: 0.1,
-                numBoostRound: 2);
+                numberOfIterations: 2);
 
             // Fit this Pipeline to the Training Data.
             var model = pipeline.Fit(split.TrainSet);

docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Ranking/LightGbmWithOptions.cs

@@ -23,10 +23,10 @@ public static void Example()
             var pipeline = mlContext.Ranking.Trainers.LightGbm(
                 new Options
                 {
-                    NumLeaves = 4,
-                    MinDataPerLeaf = 10,
+                    NumberOfLeaves = 4,
+                    MinimumDataPerLeaf = 10,
                     LearningRate = 0.1,
-                    NumBoostRound = 2,
+                    NumberOfIterations = 2,
                     Booster = new TreeBooster.Options
                     {
                         FeatureFraction = 0.9

docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Regression/LightGbm.cs

@@ -35,8 +35,8 @@ public static void Example()
             var pipeline = mlContext.Transforms.Concatenate("Features", featureNames)
                            .Append(mlContext.Regression.Trainers.LightGbm(
                                             labelColumnName: labelName,
-                                            numLeaves: 4,
-                                            minDataPerLeaf: 6,
+                                            leafCount: 4,
+                                            minimumDataPerLeaf: 6,
                                             learningRate: 0.001));
 
             // Fit this pipeline to the training data.

docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Regression/LightGbmWithOptions.cs

@@ -39,8 +39,8 @@ public static void Example()
                            .Append(mlContext.Regression.Trainers.LightGbm(new Options
                            {
                                LabelColumnName = labelName,
-                               NumLeaves = 4,
-                               MinDataPerLeaf = 6,
+                               NumberOfLeaves = 4,
+                               MinimumDataPerLeaf = 6,
                                LearningRate = 0.001,
                                Booster = new GossBooster.Options
                                {

docs/samples/Microsoft.ML.Samples/Static/LightGBMRegression.cs

@@ -38,8 +38,8 @@ public static void LightGbmRegression()
                 .Append(r => (r.label, score: mlContext.Regression.Trainers.LightGbm(
                                             r.label,
                                             r.features,
-                                            numLeaves: 4,
-                                            minDataPerLeaf: 6,
+                                            numberOfLeaves: 4,
+                                            minimumDataPerLeaf: 6,
                                             learningRate: 0.001,
                                         onFit: p => pred = p)
                                 )

src/Microsoft.ML.LightGBM.StaticPipe/LightGbmStaticExtensions.cs

@@ -21,10 +21,10 @@ public static class LightGbmStaticExtensions
         /// <param name="label">The label column.</param>
         /// <param name="features">The features column.</param>
         /// <param name="weights">The weights column.</param>
-        /// <param name="numLeaves">The number of leaves to use.</param>
-        /// <param name="numBoostRound">Number of iterations.</param>
-        /// <param name="minDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
+        /// <param name="numberOfLeaves">The number of leaves to use.</param>
+        /// <param name="minimumDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
         /// <param name="learningRate">The learning rate.</param>
+        /// <param name="numberOfIterations">Number of iterations.</param>
         /// <param name="onFit">A delegate that is called every time the
         /// <see cref="Estimator{TInShape, TOutShape, TTransformer}.Fit(DataView{TInShape})"/> method is called on the
         /// <see cref="Estimator{TInShape, TOutShape, TTransformer}"/> instance created out of this. This delegate will receive
@@ -39,19 +39,19 @@ public static class LightGbmStaticExtensions
         /// </example>
         public static Scalar<float> LightGbm(this RegressionCatalog.RegressionTrainers catalog,
             Scalar<float> label, Vector<float> features, Scalar<float> weights = null,
-            int? numLeaves = null,
-            int? minDataPerLeaf = null,
+            int? numberOfLeaves = null,
+            int? minimumDataPerLeaf = null,
             double? learningRate = null,
-            int numBoostRound = Options.Defaults.NumBoostRound,
+            int numberOfIterations = Options.Defaults.NumberOfIterations,
             Action<LightGbmRegressionModelParameters> onFit = null)
         {
-            CheckUserValues(label, features, weights, numLeaves, minDataPerLeaf, learningRate, numBoostRound, onFit);
+            CheckUserValues(label, features, weights, numberOfLeaves, minimumDataPerLeaf, learningRate, numberOfIterations, onFit);
 
             var rec = new TrainerEstimatorReconciler.Regression(
                (env, labelName, featuresName, weightsName) =>
                {
-                   var trainer = new LightGbmRegressorTrainer(env, labelName, featuresName, weightsName, numLeaves,
-                       minDataPerLeaf, learningRate, numBoostRound);
+                   var trainer = new LightGbmRegressorTrainer(env, labelName, featuresName, weightsName, numberOfLeaves,
+                       minimumDataPerLeaf, learningRate, numberOfIterations);
                    if (onFit != null)
                        return trainer.WithOnFitDelegate(trans => onFit(trans.Model));
                    return trainer;
@@ -122,11 +122,13 @@ public static Scalar<float> LightGbm(this RegressionCatalog.RegressionTrainers c
         /// ]]></format>
         /// </example>
         public static (Scalar<float> score, Scalar<float> probability, Scalar<bool> predictedLabel) LightGbm(this BinaryClassificationCatalog.BinaryClassificationTrainers catalog,
-            Scalar<bool> label, Vector<float> features, Scalar<float> weights = null,
+            Scalar<bool> label,
+            Vector<float> features,
+            Scalar<float> weights = null,
             int? numLeaves = null,
             int? minDataPerLeaf = null,
             double? learningRate = null,
-            int numBoostRound = Options.Defaults.NumBoostRound,
+            int numBoostRound = Options.Defaults.NumberOfIterations,
             Action<CalibratedModelParametersBase<LightGbmBinaryModelParameters, PlattCalibrator>> onFit = null)
         {
             CheckUserValues(label, features, weights, numLeaves, minDataPerLeaf, learningRate, numBoostRound, onFit);
@@ -194,9 +196,9 @@ public static (Scalar<float> score, Scalar<float> probability, Scalar<bool> pred
         /// <param name="features">The features column.</param>
         /// <param name="groupId">The groupId column.</param>
         /// <param name="weights">The weights column.</param>
-        /// <param name="numLeaves">The number of leaves to use.</param>
-        /// <param name="numBoostRound">Number of iterations.</param>
-        /// <param name="minDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
+        /// <param name="numberOfLeaves">The number of leaves to use.</param>
+        /// <param name="numberOfIterations">Number of iterations.</param>
+        /// <param name="minimumDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
         /// <param name="learningRate">The learning rate.</param>
         /// <param name="onFit">A delegate that is called every time the
         /// <see cref="Estimator{TInShape, TOutShape, TTransformer}.Fit(DataView{TInShape})"/> method is called on the
@@ -206,21 +208,24 @@ public static (Scalar<float> score, Scalar<float> probability, Scalar<bool> pred
         /// <returns>The set of output columns including in order the predicted binary classification score (which will range
         /// from negative to positive infinity), the calibrated prediction (from 0 to 1), and the predicted label.</returns>
         public static Scalar<float> LightGbm<TVal>(this RankingCatalog.RankingTrainers catalog,
-           Scalar<float> label, Vector<float> features, Key<uint, TVal> groupId, Scalar<float> weights = null,
-            int? numLeaves = null,
-            int? minDataPerLeaf = null,
+            Scalar<float> label,
+            Vector<float> features,
+            Key<uint, TVal> groupId,
+            Scalar<float> weights = null,
+            int? numberOfLeaves = null,
+            int? minimumDataPerLeaf = null,
             double? learningRate = null,
-            int numBoostRound = Options.Defaults.NumBoostRound,
+            int numberOfIterations = Options.Defaults.NumberOfIterations,
             Action<LightGbmRankingModelParameters> onFit = null)
         {
-            CheckUserValues(label, features, weights, numLeaves, minDataPerLeaf, learningRate, numBoostRound, onFit);
+            CheckUserValues(label, features, weights, numberOfLeaves, minimumDataPerLeaf, learningRate, numberOfIterations, onFit);
             Contracts.CheckValue(groupId, nameof(groupId));
 
             var rec = new TrainerEstimatorReconciler.Ranker<TVal>(
                (env, labelName, featuresName, groupIdName, weightsName) =>
                {
-                   var trainer = new LightGbmRankingTrainer(env, labelName, featuresName, groupIdName, weightsName, numLeaves,
-                       minDataPerLeaf, learningRate, numBoostRound);
+                   var trainer = new LightGbmRankingTrainer(env, labelName, featuresName, groupIdName, weightsName, numberOfLeaves,
+                       minimumDataPerLeaf, learningRate, numberOfIterations);
 
                    if (onFit != null)
                        return trainer.WithOnFitDelegate(trans => onFit(trans.Model));
@@ -279,10 +284,10 @@ public static Scalar<float> LightGbm<TVal>(this RankingCatalog.RankingTrainers c
         /// <param name="label">The label, or dependent variable.</param>
         /// <param name="features">The features, or independent variables.</param>
         /// <param name="weights">The weights column.</param>
-        /// <param name="numLeaves">The number of leaves to use.</param>
-        /// <param name="numBoostRound">Number of iterations.</param>
-        /// <param name="minDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
+        /// <param name="numberOfLeaves">The number of leaves to use.</param>
+        /// <param name="minimumDataPerLeaf">The minimal number of documents allowed in a leaf of the tree, out of the subsampled data.</param>
         /// <param name="learningRate">The learning rate.</param>
+        /// <param name="numberOfIterations">Number of iterations.</param>
         /// <param name="onFit">A delegate that is called every time the
         /// <see cref="Estimator{TInShape, TOutShape, TTransformer}.Fit(DataView{TInShape})"/> method is called on the
         /// <see cref="Estimator{TInShape, TOutShape, TTransformer}"/> instance created out of this. This delegate will receive
@@ -301,19 +306,19 @@ public static (Vector<float> score, Key<uint, TVal> predictedLabel)
             Key<uint, TVal> label,
             Vector<float> features,
             Scalar<float> weights = null,
-            int? numLeaves = null,
-            int? minDataPerLeaf = null,
+            int? numberOfLeaves = null,
+            int? minimumDataPerLeaf = null,
             double? learningRate = null,
-            int numBoostRound = Options.Defaults.NumBoostRound,
+            int numberOfIterations = Options.Defaults.NumberOfIterations,
             Action<OvaModelParameters> onFit = null)
         {
-            CheckUserValues(label, features, weights, numLeaves, minDataPerLeaf, learningRate, numBoostRound, onFit);
+            CheckUserValues(label, features, weights, numberOfLeaves, minimumDataPerLeaf, learningRate, numberOfIterations, onFit);
 
             var rec = new TrainerEstimatorReconciler.MulticlassClassifier<TVal>(
                 (env, labelName, featuresName, weightsName) =>
                 {
-                    var trainer = new LightGbmMulticlassTrainer(env, labelName, featuresName, weightsName, numLeaves,
-                       minDataPerLeaf, learningRate, numBoostRound);
+                    var trainer = new LightGbmMulticlassTrainer(env, labelName, featuresName, weightsName, numberOfLeaves,
+                       minimumDataPerLeaf, learningRate, numberOfIterations);
 
                     if (onFit != null)
                         return trainer.WithOnFitDelegate(trans => onFit(trans.Model));