Skip to content

Scrubbing LightGBM learnears #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ivanidzo4ka opened this issue Feb 19, 2019 · 1 comment
Closed

Scrubbing LightGBM learnears #2618

Ivanidzo4ka opened this issue Feb 19, 2019 · 1 comment
Assignees
@singlis
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@Ivanidzo4ka
Copy link
Contributor

Sub task of #2613
LightGbmBinaryTrainer
LightGbmMulticlassTrainer
LightGbmRankingTrainer
LightGbmRegressorTrainer
and their base classes
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 19, 2019
@singlis singlis self-assigned this Feb 26, 2019
singlis added a commit to singlis/machinelearning that referenced this issue Mar 1, 2019
@singlis
Api clean up for LightGBM. The cleanup includes:

Verified

This commit was signed with the committer’s verified signature. The key has expired.
max-sixty Maximilian Roos
GPG key ID: 3232F28BEDA66FCD
Expired
Verified
Learn about vigilant mode
8dd53e1 
- Changing all abbreviated parameters to full names (i.e. numThreads->NumberOfThreads)
- Updating column parameters to have Name if thats what they represent
(LabelColumn->LabelColumnName).
- Updated baseline files to reflect these changes which are semantical
and should not have any computational difference.

This fixes dotnet#2618
@singlis singlis mentioned this issue Mar 1, 2019
Merged
singlis added a commit that referenced this issue Mar 5, 2019
@singlis
Scrub changes for LightGBM (#2808)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d28886f 
Api clean up for LightGBM. The cleanup includes:
- Changing all abbreviated parameters to full names (i.e. numThreads->NumberOfThreads)
- Moving protected to private protected
- Updated baseline files to reflect these changes which are semantical
and should not have any computational difference.

Part of the fix for #2618
@shauheen
Copy link
Contributor

@Ivanidzo4ka is this issue resolved with #2808 ?

@shauheen shauheen added this to the 0319 milestone Mar 15, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@singlis singlis

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

No branches or pull requests
3 participants
@Ivanidzo4ka @shauheen @singlis