Skip to content

Tests: simplify the PHPCS setup method [1] #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Tests: simplify the PHPCS setup method [1] #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions VariableAnalysis/Tests/BaseTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,17 @@
use PHP_CodeSniffer\Config;

class BaseTestCase extends TestCase {
public function prepareLocalFileForSniffs($sniffFiles, $fixtureFile) {
$config = new Config(['--standard=VariableAnalysis']);
$ruleset = new Ruleset($config);
if (! is_array($sniffFiles)) {
$sniffFiles = [$sniffFiles];
}
const STANDARD_NAME = 'VariableAnalysis';
const SNIFF_FILE = __DIR__ . '/../Sniffs/CodeAnalysis/VariableAnalysisSniff.php';

public function prepareLocalFileForSniffs($fixtureFile) {
$config = new Config();
$config->cache = false;
$config->standards = [self::STANDARD_NAME];
$config->ignored = [];

$sniffFiles = [realpath(self::SNIFF_FILE)];
$ruleset = new Ruleset($config);
$ruleset->registerSniffs($sniffFiles, [], []);
$ruleset->populateTokenListeners();
if (! file_exists($fixtureFile)) {
Expand All @@ -35,10 +40,6 @@ public function getErrorLineNumbersFromFile(LocalFile $phpcsFile) {
return $this->getLineNumbersFromMessages($phpcsFile->getErrors());
}

public function getSniffFiles() {
return [realpath(__DIR__ . '/../../VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php')];
}

public function getFixture($fixtureFilename) {
return realpath(__DIR__ . '/CodeAnalysis/fixtures/' . $fixtureFilename);
}
Expand Down
Loading