Bug fix: $this in nested function declaration #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `$this` can be used freely within classes, traits and closures, if a nested closed scope is defined within any of these, `$this` is not inherited and should be considered undefined. As things were, the sniff would not throw a warning for this (false negative). This commit fixes this. Includes unit tests. Includes removing an outdated comment. `T_CLOSURE` works perfectly fine with the conditions array (and has for quite a few years). Fixes 109
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
$thiscan be used freely within classes, traits and closures, if a nested closed scope is defined within any of these,$thisis not inherited and should be considered undefined.As things were, the sniff would not throw a warning for this (false negative).
This commit fixes this.
Includes unit tests.
Includes removing an outdated comment.
T_CLOSUREworks perfectly fine with the conditions array (and has for quite a few years).Fixes #109