Skip to content

Downgrade requirements from PHP 5.6 to 5.4 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 11, 2020
Merged

Downgrade requirements from PHP 5.6 to 5.4 #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccb6fe2
Add php 5.4 to circleci config
sirbrillig Jul 11, 2020
d44b925
Downgrade required php version to 5.4
sirbrillig Jul 11, 2020
5375c7c
Allow phpunit 4 for testing
sirbrillig Jul 11, 2020
25c6774
Remove constant expression from BaseTestCase
sirbrillig Jul 11, 2020
d6ac366
Use func_get_args instead of ellipses
sirbrillig Jul 11, 2020
90af293
Downgrade PHP requirement in README
sirbrillig Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,35 @@ jobs:
- checkout
- run: COMPOSER=composer.circleci.json composer install
- run: COMPOSER=composer.circleci.json composer test
build_php5.4:
docker:
- image: lavoweb/php-5.4
steps:
- run:
name: PHP version check
command: php --version
- run:
name: Install system packages
command: apt-get update && apt-get -y install git
- checkout
- run:
name: Install composer
command: |
php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
php -r "if (hash_file('SHA384', 'composer-setup.php') === trim(file_get_contents('https://composer.github.io/installer.sig'))) { echo 'Installer verified'; } else { echo 'Installer invalid'; unlink('composer-setup.php'); } echo PHP_EOL;"
php composer-setup.php
php -r "unlink('composer-setup.php');"
- run:
name: Install dependencies
command: COMPOSER=composer.circleci.json php composer.phar install
- run:
name: Run tests
command: COMPOSER=composer.circleci.json php composer.phar test
workflows:
version: 2
build_php_versions:
jobs:
- build_php5.4
- build_php5.6
- build_php7.3
- build_php7.4
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Plugin for PHP_CodeSniffer static analysis tool that adds analysis of problemati

### Requirements

VariableAnalysis requires PHP 5.6 or higher and [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) version 3.5.0 or higher.
VariableAnalysis requires PHP 5.4 or higher and [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) version 3.5.0 or higher.

It also requires [PHPCSUtils](https://phpcsutils.com/) which must be installed as a PHPCS standard. If you are using composer, this will be done automatically (see below).

Expand Down Expand Up @@ -97,7 +97,7 @@ This was forked from the excellent work in https://github.com/illusori/PHP_Codes

Please open issues or PRs on this repository.

Any changes should be accompanied by tests and should pass linting and static analysis. Please use phpdoc (rather than actual types) for declaring types since this must run in PHP 5.6.
Any changes should be accompanied by tests and should pass linting and static analysis. Please use phpdoc (rather than actual types) for declaring types since this must run in PHP 5.4.

To run tests, make sure composer is installed, then run:

Expand Down
5 changes: 3 additions & 2 deletions Tests/BaseTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@

class BaseTestCase extends TestCase {
const STANDARD_NAME = 'VariableAnalysis';
const SNIFF_FILE = __DIR__ . '/../VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php';

public function prepareLocalFileForSniffs($fixtureFile) {
$sniffFile = __DIR__ . '/../VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php';

$config = new Config();
$config->cache = false;
$config->standards = [self::STANDARD_NAME];
$config->ignored = [];

$sniffFiles = [realpath(self::SNIFF_FILE)];
$sniffFiles = [realpath($sniffFile)];
$ruleset = new Ruleset($config);
$ruleset->registerSniffs($sniffFiles, [], []);
$ruleset->populateTokenListeners();
Expand Down
3 changes: 2 additions & 1 deletion VariableAnalysis/Lib/Helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,8 @@ public static function getVariablesDefinedByArrowFunction(File $phpcsFile, $stac
/**
* @return void
*/
public static function debug(...$messages) {
public static function debug() {
$messages = func_get_args();
if (! defined('PHP_CODESNIFFER_VERBOSITY')) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions composer.circleci.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"test": "./vendor/bin/phpunit --configuration phpunit.circleci.xml"
},
"require" : {
"php" : ">=5.6.0",
"php" : ">=5.4.0",
"squizlabs/php_codesniffer": "^3.1",
"phpcsstandards/phpcsutils": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^5.0 || ^6.5 || ^7.0 || ^8.0"
"phpunit/phpunit": "^4.0 || ^5.0 || ^6.5 || ^7.0 || ^8.0"
}
}
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"phpstan": "./vendor/bin/phpstan analyse"
},
"require" : {
"php" : ">=5.6.0",
"php" : ">=5.4.0",
"squizlabs/php_codesniffer": "^3.5",
"phpcsstandards/phpcsutils": "^1.0"
},
Expand Down