[GCP/Auth] Use the application key in the env var #2116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2115 and #2109.
The problem causing the two issues is that we hardcoded the application default key path in our code to find the credentials. However, the user may specify the key in the environment variable
GOOGLE_APPLICATION_CREDENTIALS
We now first check the env var to look for the credential file, if the env var does not exist, we will use the default path (same as the gcloud's behavior).
TODO:
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
with the service account. (except for TPU VM and azure_start_stop [Core] Avoid uploading public key #2119)pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh