CLI: make sky down/stop/start default to a unique cluster if exists.
#2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
changed the title
sky down/stop default to a unique cluster if exists.sky down/stop/start default to a unique cluster if exists.
landscapepainter
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
@concretevitamin Tried this out and all works well! One unexpected behavior was that sky start currently doesn't display any outputs when there is 0 cluster in status while stop/down does. Is this intended?
(base) root@e3f961aef279:~# sky status
Clusters
No existing clusters.
Managed spot jobs
No in progress jobs. (See: sky spot -h)
(base) root@e3f961aef279:~# sky start
(base) root@e3f961aef279:~# sky stop
Cluster(s) not found (tip: see `sky status`).
(base) root@e3f961aef279:~# sky down
Cluster(s) not found (tip: see `sky status`).
When there are >1 clusters, it does behave as expeced:
Clusters
NAME LAUNCHED RESOURCES STATUS AUTOSTOP COMMAND
sky-0fb2-root < 1 sec 1x AWS(m6i.2xlarge) UP - sky launch --cloud aws -y
sky-d04e-root 3 mins ago 1x AWS(m6i.2xlarge) UP - sky start
(base) root@e3f961aef279:~# sky stop
Usage: sky stop [OPTIONS] [CLUSTERS]...
Try 'sky stop -h' for help.
Error: `sky stop` requires either a cluster name or glob, or the -a/--all flag.
(base) root@e3f961aef279:~# sky start
Usage: sky start [OPTIONS] [CLUSTERS]...
Try 'sky start -h' for help.
Error: `sky start` requires either a cluster name or glob, or the -a/--all flag.
sky/cli.py
Outdated
| clusters = all_cluster_names | ||
| else: | ||
| raise click.UsageError( | ||
| '`sky start` requires either a cluster name or glob, ' |
There was a problem hiding this comment.
Suggested change
| '`sky start` requires either a cluster name or glob, ' | |
| '`sky start` requires either a cluster name (see `sky status`) or glob, ' |
I'm wondering if we should keep the (see 'sky status') to inform (same for sky stop/down)?
concretevitamin
commented
Jul 31, 2023
sky/cli.py
Outdated
| clusters = all_cluster_names | ||
| else: | ||
| raise click.UsageError( | ||
| '`sky start` requires either a cluster name or glob, ' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #1877.
When I have only 1 cluster in
status:Previously
This PR makes it so that
down/stopdefaults to it:When I have 0 cluster in
status: this PRSame for
sky start.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh